[committed] Skip gcc.dg/torture/pr60092.c on 32-bit hpux

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Mon Mar 24 14:12:00 GMT 2014


John David Anglin <dave.anglin@bell.net> writes:

> On 3/24/2014 2:45 AM, Rainer Orth wrote:
>> John David Anglin <dave.anglin@bell.net> writes:
>>
>>> Index: gcc.dg/torture/pr60092.c
>>> ===================================================================
>>> --- gcc.dg/torture/pr60092.c	(revision 208769)
>>> +++ gcc.dg/torture/pr60092.c	(working copy)
>>> @@ -1,5 +1,6 @@
>>>   /* { dg-do run } */
>>>   /* { dg-require-weak "" } */
>>> +/* { dg-skip-if "No undefined weak" { hppa*-*-hpux* && { ! lp64 } } {
>>> "*" } { "" } } */
>> Please omit those default args to dg-skip-if.  Besides, it seems we
>> should have a separate undefined_weak (or whatever) keyword for this,
>> rather than listing targets explicitly.  But that's certainly not 4.9
>> material.
> I agree.  I'll see about removing the default arguments.  There are a bunch
> of  tests

Thanks.

> with the same dg-skip-if statement.

I know.  I mean to make a pass over the whole testsuite removing those
(now superfluous) default args.  This stuff tends to be just copied
around, so it will resurface over and over again.  Same for other stuff:
our testsuite is riddled with copy-and-paste programming ;-)

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Gcc-patches mailing list