[testsuite] Fix gcc.dg/tls/pr58595.c on Solaris 9

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Wed Mar 19 12:12:00 GMT 2014


Jakub Jelinek <jakub@redhat.com> writes:

> On Tue, Mar 18, 2014 at 11:19:52AM +0100, Rainer Orth wrote:
>> The new gcc.dg/tls/pr58595.c testcase FAILs on Solaris 9:
>> 
>> FAIL: gcc.dg/tls/pr58595.c (test for excess errors)
>> Excess errors:
>> Undefined                       first referenced
>>  symbol                             in file
>> ___tls_get_addr                     /var/tmp//ccuBbAna.o
>> ld: fatal: Symbol referencing errors. No output written to ./pr58595.exe
>> WARNING: gcc.dg/tls/pr58595.c compilation failed to produce executable
>> 
>> Fixed as follows, tested with the appropriate runtest invocation on
>> i386-pc-solaris2.9, i386-pc-solaris2.11, and x86_64-unknown-linux-gnu,
>> installed on mainline.
>
> Can you please also change
> /* { dg-require-effective-target tls } */
> to
> /* { dg-require-effective-target tls_runtime } */
> ?

Sure, done as follows after retesting as before:

2014-03-19  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gcc.dg/tls/pr58595.c: Require tls_runtime instead of tls.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tls.patch
Type: text/x-patch
Size: 689 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140319/5de5d88e/attachment.bin>
-------------- next part --------------

> BTW, don't know if dg-add-options tls can come before that or not.

It can: the tls_runtime check takes care of adding the options itself.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the Gcc-patches mailing list