[patch,avr] Fix PR60486: Typo cc_plus against cc_minus in calls of avr_out_plus_1

Denis Chertykov chertykov@gmail.com
Thu Mar 13 08:33:00 GMT 2014


2014-03-12 17:35 GMT+04:00 Georg-Johann Lay <avr@gjlay.de>:
> This fixes a problem because cc_plus and cc_minus are in the wrong places in
> calls of avr_out_plus_1.  This is important when avr_out_plus is called from
> notice_update_cc.  This means that cc_status might be determined
> incorrectly.
>
> In the vast majority of cases this leads to performance regression because
> of superfluous comparisons when an addition (using SUB instructions) has
> already set the condition code.
>
> But there are also cases where this might lead to wrong code.
>
> No changes in test suite results.
>
> Ok to apply?
>
>
> I didn't follow this list for some time. Is trunk open for such changes?
>
> If so, I would apply it to trunk and 4.8 branch, otherwise to 4.8, 4.9 and
> trunk once they are open again.
>

Please apply.
As I remember the trunk always open for port specific changes.

Denis.



More information about the Gcc-patches mailing list