[PATCH, libgcc]: Avoid warning: array subscript is above array bounds when compiling crtstuff.c

Jakub Jelinek jakub@redhat.com
Mon Mar 10 18:43:00 GMT 2014


On Mon, Mar 10, 2014 at 10:53:27AM -0700, Ian Lance Taylor wrote:
> On Mon, Mar 10, 2014 at 10:42 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > Attached patch is what I plan to commit to mainline soon. Ian, does it
> > look OK to you?
> >
> > 2014-03-10  Uros Bizjak  <ubizjak@gmail.com>
> >
> >     * crtstuff.c (frame_dummy): Use void **jcr_list temporary
> >     variable to avoid array subscript is above array bounds warnings.
> >     Use __builtin_expect when checking *jcr_list for NULL.
> 
> This looks OK to me.  Thanks.
> 
> > Jakub, is it OK for mainline from RMs POV? Shall we backport this
> > patch to other release branches?
> 
> I gather that the purpose of this patch is to avoid a warning.  I
> don't see a reason to backport this to working release branches.

Yeah.  Unless we are aware of miscompilation on some target, I think it
shouldn't be backported.

	Jakub



More information about the Gcc-patches mailing list