[PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

[Richard Biener]

On Fri, Mar 7, 2014 at 9:59 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, Mar 7, 2014 at 12:29 AM, Paulo Matos <paulo@matos-sorge.com> wrote:
>> On 06/03/14 11:19, Richard Biener wrote:
>>>
>>> On Wed, Mar 5, 2014 at 12:55 PM, Paulo Matos <paulo@matos-sorge.com>
>>> wrote:
>>>>
>>>> On 05/03/2014 11:51, Richard Biener wrote:
>>>>>
>>>>>
>>>>> On Wed, Mar 5, 2014 at 12:43 PM, Dominique Dhumieres
>>>>> <dominiq@lps.ens.fr>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> Revision 208312 causes
>>>>>>
>>>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60427
>>>>>
>>>>>
>>>>>
>>>>> Uhm.  pointer comparison against double_type_node ...
>>>>>
>>>>> I'd say we want to revert the patch.  Paulo, please do that.  Let's
>>>>> do the alternate approach of marking -fshort-double eligible for LTO
>>>>> as well and handle it there properly.
>>>>>
>>>>
>>>> Sure, I will prepare a new patch and post it for approval by the end of
>>>> the
>>>> day.
>>>>
>>>> Apologies for the regression.
>>>
>>>
>>> I have reverted the patch for now.
>>>
>>> Richard.
>>>
>>
>>
>> Please find new patch attached. I have enabled LTO for short-double and
>> passed flag_short_double to build_common_tree_nodes.
>>
>> I have tested this for C on powerpc-eabipse (target for which we are fixing
>> pr55113), and C/Fortran on a x86_64. Saw no regressions.
>>
>> OK to commit?
>
> Ok.

Btw, can you check the attached as well?  It makes sure all TUs
have -fshort-double set consistently and it automatically enables
it at link-time, not allowing to override the setting.

If it works for you please check it in, too.  (I can't really test it
because -fshort-double brokeness on x86_64).

Thanks,
Richard.

> Thanks,
> Richard.
>
>> gcc/c-family/
>> 2014-03-06  Paulo Matos  <paulo@matos-sorge.com>
>>
>>         * c.opt: Enable LTO FE for fshort-double.
>>
>> gcc/lto/
>> 2014-03-06  Paulo Matos  <paulo@matos-sorge.com>
>>
>>         * lto-lang.c (lto_init): Pass flag_short_double to
>>         build_common_tree_nodes.
>>
>> gcc/testsuite/
>> 2014-03-06  Paulo Matos  <paulo@matos-sorge.com>
>>
>>         * gcc.dg/lto/pr55113_0.c: New testcase.
>>
>>
>> --
>> Paulo Matos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p
Type: application/octet-stream
Size: 965 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140307/b8bff4da/attachment.obj>