testsuite allocators patch

François Dumont frs.dumont@gmail.com
Wed Jul 23 20:46:00 GMT 2014


On 27/06/2014 21:48, Paolo Carlini wrote:
> Hi,
>
> On 06/27/2014 07:33 PM, Jonathan Wakely wrote:
>> I didn't see an obvious fix (I'm not sure if the templated constructor
>> can deduce its argument since the change) but have been out all day
>> and not had a chance to look into it.
> Ok, thanks. I'm reverting the last two libstdc++-v3 commits.
>
> Paolo.
>

Hi

     Back from vacation, ready to have this patch committed eventually.

     Here is the new version with the missing default and copy constructor.

     I have a small question regarding some code next to the one I am 
modifying in this patch. I can see lines like:

       propagating_allocator() noexcept = default;

     When using a default implementation shouldn't we let the compiler 
decide if it should be noexcept or not depending on the member fields or 
base class default constructors ?

     Tested under Linux x86_64.

     Ok to commit ?

François

-------------- next part --------------
A non-text attachment was scrubbed...
Name: testsuite_alloc.patch
Type: text/x-patch
Size: 21616 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140723/bc5dcd25/attachment.bin>


More information about the Gcc-patches mailing list