On Jul 3, 2014, at 2:53 PM, Richard Sandiford <rdsandiford@googlemail.com> wrote: > Jakub Jelinek <jakub@redhat.com> writes: >> >> + if (sgn == SIGNED && wi::neg_p (op1)) > > I think the preferred way of writing this is "wi::neg_p (op1, svn)" Yes.