[PATCH][C] Fix PR59905, remove code replacing calls with abort

Joseph S. Myers joseph@codesourcery.com
Wed Jan 29 17:06:00 GMT 2014


On Wed, 29 Jan 2014, Richard Biener wrote:

> testing reveals diagnostic regressions
> 
> FAIL: gcc.dg/call-diag-2.c abort (test for warnings, line 12)
> FAIL: gcc.dg/call-diag-2.c abort (test for warnings, line 15)
> FAIL: gcc.dg/invalid-call-1.c  (test for warnings, line 16)
> 
> which may be hard to preserve (didn't investigate thoroughly yet),
> one is probably emitted via the call to require_complete_type
> I remove.
> 
> Is it ok to adjust the testcases expectation for what is produced now?

These appear to be about the "will abort" diagnostics - removing those 
dg-message tests, while keeping the dg-warning tests, is fine.

I do think we need a public ubsan todo list, if there isn't already one, 
and sanitization of calls through incompatible types should go on that 
list.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list