[PATCH, ARM][PING] Reintroduce minipool ranges for zero-extension insn patterns

Julian Brown julian@codesourcery.com
Tue Jan 28 12:29:00 GMT 2014


On Tue, 28 Jan 2014 12:09:27 +0000
Ramana Radhakrishnan <ramana.gcc@googlemail.com> wrote:

> On Thu, Jan 23, 2014 at 3:16 PM, Yury Gribov <y.gribov@samsung.com>
> wrote:
> > Hi,
> >
> > Julian Brown has proposed patch
> > (http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01191.html) for the
> > dreadful push_minipool_fix error
> > (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49423) in June but it
> > didn't seem to get enough attention.#
> 
> 
> That patch appears to be garbled with text that appears to be from a
> testcase.

That's bizarre! I have no idea how that can have happened.

> It needs to be rebased for trunk to deal with the additional
> changes to the attributes currently.. Additionally I'm not really sure
> why there is an additional load from the constant pool here - what is
> the constant in this case ? Given it is atmost a 16 bit constant
> surely that should be loaded with a single mov(w) instruction in armv7
> land.

I've lost the context on this patch now, but I may be able to have a
look some time in the next few days and refresh my memory --
particularly if there's a testcase available that reproduces on current
mainline.

Thanks,

Julian



More information about the Gcc-patches mailing list