Two build != host fixes

Alan Modra amodra@gmail.com
Tue Jan 28 07:27:00 GMT 2014


On Fri, Jan 24, 2014 at 10:34:10AM -0700, Jeff Law wrote:
> >Of course, then your question becomes, why exclude CPPFLAGS?  (And if
> >CPPFLAGS needs to be excluded here, then I should have just used
> >CPPFLAGS=-DGENERATOR_FILE for the recursive configure call..)  I'm not
> >sure now, I'll have to do some digging.  Also as to why @INCINTL@ was
> >removed, when gettext is potentially needed for the gen programs.
> Thanks.  My inclination is to go forward with this hunk as well,
> with any tweaks you find after investigating the situation around
> CPPFLAGS.

I committed the configure.ac change as is and restored CPPFLAGS
and @INCINTL@ to the Makefile.in BUILD_CPPFLAGS.

CPPFLAGS is set from the top level makefile CPPFLAGS_FOR_TARGET.  It's
questionable whether using CPPFLAGS_FOR_TARGET is really correct for
BUILD_CPPFLAGS but leaving it in is probably safer.  Who knows what
weird use is being made of CPPFLAGS_FOR_TARGET?

@INCINTL@ is set to -I${top_builddir}/../intl when someone configures
using --with-included-gettext.  It seems reasonable to me that
-with-included-gettext affect both build and host.

Thanks everyone for your patience.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Gcc-patches mailing list