Two build != host fixes

Jeff Law law@redhat.com
Fri Jan 24 17:34:00 GMT 2014


On 01/23/14 16:02, Alan Modra wrote:
> On Wed, Jan 22, 2014 at 09:21:46PM -0700, Jeff Law wrote:
>>> 	* Makefile.in (BUILD_CPPFLAGS): Do not use ALL_CPPFLAGS.
>>> 	* configure.ac <recursive call for build != host>: Define
>>> 	GENERATOR_FILE.  Comment.  Use CXX_FOR_BUILD, CXXFLAGS_FOR_BUILD
>>> 	and LD_FOR_BUILD too.
>>> 	* configure: Regenerate.
>> The configure.ac changes look fine to me.
>
> Thanks!  That part alone ought to fix the in-tree gmp breakage.
Feel free to push that one through now since it seems like a bit of a 
no-brainer.


>
>> Not sure about the Makefile.in changes, probably because I simply
>> don't understand this mess anymore.  Is it the $INCLUDES or
>> $CPPFLAGS from ALL_CPPFLAGS that causes the problem?  I'm guessing
>> the latter since it's substituted via @CPPFLAGS@.
>>
>> If so, shouldn't we use BUILD_CPPFLAGS=$INCLUDES $(CPPINC)?
>
> INCLUDES is the problem.
>
> INCLUDES = -I. -I$(@D) -I$(srcdir) -I$(srcdir)/$(@D) \
> 	   -I$(srcdir)/../include @INCINTL@ \
> 	   $(CPPINC) $(GMPINC) $(DECNUMINC) $(BACKTRACEINC) \
> 	   $(CLOOGINC) $(ISLINC)
?!?  Not sure how I missed that.  Yea, and thanks for touching on ISLINC 
and CLOOGINC since those were my first thoughts when I looked at this again.

> Of course, then your question becomes, why exclude CPPFLAGS?  (And if
> CPPFLAGS needs to be excluded here, then I should have just used
> CPPFLAGS=-DGENERATOR_FILE for the recursive configure call..)  I'm not
> sure now, I'll have to do some digging.  Also as to why @INCINTL@ was
> removed, when gettext is potentially needed for the gen programs.
Thanks.  My inclination is to go forward with this hunk as well, with 
any tweaks you find after investigating the situation around CPPFLAGS.

Jeff




More information about the Gcc-patches mailing list