[Patch, microblaze]: Fix ICE with mhard-float
Thu Jan 16 18:36:00 GMT 2014
On 11/25/13 23:50, David Holsgrove wrote:
> Hi Michael,
> I've attached the same patch based on latest gcc master.
> Can this be applied to gcc-4_8-branch also.
> On 15 July 2013 14:53, David Holsgrove <firstname.lastname@example.org> wrote:
>> Add SImode to cstoresf4's comparison operator, prevents ICE during combine
>> rtl pass with error message;
>> internal compiler error: in simplify_subreg, at simplify-rtx.c:5725
>> Use ordered_comparison_operator predicate to limit operators to
>> those fcmp can handle, and letting compiler reorder insns to
>> accommodate unordered as necessary.
>> Changelog entry;
>> 2013-07-15 David Holsgrove <email@example.com>
>> * gcc/config/microblaze/microblaze.md: Fix cstoresf4 and cbranchsf4
>> Can this be backported to gcc-4_8-branch also?
Hi David --
You mention that this patch fixes an ICE. Is there a failing test
case in the GCC Test Suite? Is there a GCC PR for this ICE?
If not, please add a test case to the patch.
Changelog entries saying "fix XYZ" are not as useful as a description
of the changes made. A better Changelog would be:
* config/microblaze/microblaze.md (cstoresf4, cbranchsf4): Replace
comparison_operator with ordered_comparison_operator.
Michael Eager firstname.lastname@example.org
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
More information about the Gcc-patches