PATCH: PR target/59794: [4.7/4.8/4.9 Regression] i386 backend fails to detect MMX/SSE/AVX ABI changes

Jakub Jelinek jakub@redhat.com
Wed Jan 15 07:09:00 GMT 2014


On Tue, Jan 14, 2014 at 06:18:22AM -0800, H.J. Lu wrote:
> 2014-01-14  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR target/59794
> 	* config/i386/i386.c (type_natural_mode): Add a bool parameter
> 	to indicate if type is used for function return value.  Warn
> 	ABI change if the vector mode isn't available for function
> 	return value.
> 	(ix86_function_arg_advance): Pass false to type_natural_mode.
> 	(ix86_function_arg): Likewise.
> 	(ix86_gimplify_va_arg): Likewise.
> 	(function_arg_32): Don't warn ABI change.
> 	(ix86_function_value): Pass true to type_natural_mode.
> 	(ix86_return_in_memory): Likewise.
> 	(ix86_struct_value_rtx): Removed.
> 	(TARGET_STRUCT_VALUE_RTX): Likewise.

This has added many FAILs on i686-linux (make sure to configure for a CPU
that doesn't automatically turn on -msse or -mmmx, say i686):

+FAIL: gcc.dg/Wstrict-aliasing-bogus-ref-all-2.c (test for excess errors)
+FAIL: gcc.dg/pr53060.c (test for excess errors)
+FAIL: c-c++-common/convert-vec-1.c  -Wc++-compat  (test for excess errors)
+FAIL: c-c++-common/scal-to-vec2.c  -Wc++-compat  (test for excess errors)
+FAIL: c-c++-common/vector-compare-2.c  -Wc++-compat  (test for excess errors)
+FAIL: g++.dg/conversion/simd1.C -std=c++98 (test for excess errors)
+FAIL: g++.dg/conversion/simd1.C -std=c++11 (test for excess errors)
+FAIL: g++.dg/cpp0x/constexpr-53094-2.C (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-1.C -std=gnu++98 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-1.C -std=gnu++11 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-2.C -std=gnu++98 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-2.C -std=gnu++11 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-3.C -std=c++98 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-3.C -std=c++11 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-4.C -std=c++98 (test for excess errors)
+FAIL: g++.dg/ext/attribute-test-4.C -std=c++11 (test for excess errors)
+FAIL: g++.dg/ext/pr56790-1.C -std=gnu++98 (test for excess errors)
+FAIL: g++.dg/ext/pr56790-1.C -std=gnu++11 (test for excess errors)
+FAIL: c-c++-common/convert-vec-1.c -std=c++98 (test for excess errors)
+FAIL: c-c++-common/convert-vec-1.c -std=c++11 (test for excess errors)
+FAIL: c-c++-common/scal-to-vec2.c -std=gnu++98 (test for excess errors)
+FAIL: c-c++-common/scal-to-vec2.c -std=gnu++11 (test for excess errors)
+FAIL: c-c++-common/vector-compare-2.c -std=gnu++98 (test for excess errors)
+FAIL: c-c++-common/vector-compare-2.c -std=gnu++11 (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O0  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O1  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O2  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O3 -fomit-frame-pointer  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O3 -g  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -Os  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O2 -flto -flto-partition=none  (test for excess errors)
+FAIL: g++.dg/torture/pr38565.C  -O2 -flto  (test for excess errors)

Excess errors:
/usr/src/gcc/gcc/testsuite/gcc.dg/Wstrict-aliasing-bogus-ref-all-2.c:9:1: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/gcc.dg/pr53060.c:13:1: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/c-c++-common/convert-vec-1.c:3:1: warning: MMX vector return without MMX enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/c-c++-common/scal-to-vec2.c:19:1: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/c-c++-common/vector-compare-2.c:20:1: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/conversion/simd1.C:8:59: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/cpp0x/constexpr-53094-2.C:7:46: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/ext/attribute-test-1.C:10:52: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/ext/attribute-test-2.C:14:59: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/ext/attribute-test-3.C:26:26: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/ext/attribute-test-4.C:26:24: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/ext/pr56790-1.C:6:12: warning: MMX vector return without MMX enabled changes the ABI [enabled by default]
/usr/src/gcc/gcc/testsuite/g++.dg/torture/pr38565.C:5:28: warning: SSE vector return without SSE enabled changes the ABI [enabled by default]

Please review this if the warnings are really desirable in all those tests and if yes,
dg-prune-output them (or add -Wno-psabi or whatever else turns them off).

	Jakub



More information about the Gcc-patches mailing list