[PATCH, AARCH64] MULTIARCH_DIRNAME breaks multiarch build

Zhenqiang Chen zhenqiang.chen@linaro.org
Fri Jan 10 08:23:00 GMT 2014


Hi,

MULTIARCH_DIRNAME was removed @r196649 since the dir info had been
combined in MULTILIB_OSDIRNAMES.

But MULTIARCH_DIRNAME was re-added @r201164. With this change, the
final multiarch_dir is combined as
"aarch64-linux-gnu:aarch64-linux-gnu", which is incorrect and leads to
multiarch build fail if the sysroot is in correct multiarch layout.

Any reason to add MULTIARCH_DIRNAME? If it is not necessary, can we
remove it as the patch?

Thanks!
-Zhenqiang

ChangeLog:
2014-01-10  Zhenqiang Chen  <zhenqiang.chen@linaro.org>

    * config/aarch64/t-aarch64-linux (MULTIARCH_DIRNAME): Remove.

diff --git a/gcc/config/aarch64/t-aarch64-linux
b/gcc/config/aarch64/t-aarch64-linux
index 147452b..77e33ea 100644
--- a/gcc/config/aarch64/t-aarch64-linux
+++ b/gcc/config/aarch64/t-aarch64-linux
@@ -23,7 +23,6 @@ LIB1ASMFUNCS = _aarch64_sync_cache_range

 AARCH_BE = $(if $(findstring TARGET_BIG_ENDIAN_DEFAULT=1, $(tm_defines)),_be)
 MULTILIB_OSDIRNAMES = .=../lib64$(call
if_multiarch,:aarch64$(AARCH_BE)-linux-gnu)
-MULTIARCH_DIRNAME = $(call if_multiarch,aarch64$(AARCH_BE)-linux-gnu)

 # Disable the multilib for linux-gnu targets for the time being; focus
 # on the baremetal targets.



More information about the Gcc-patches mailing list