[PATCH, go]: Skip some go tests

Ian Lance Taylor iant@google.com
Thu Jan 9 17:59:00 GMT 2014


On Thu, Jan 9, 2014 at 2:54 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
> There are two remaining warnings:
>
> go.test/test/nilcheck.go: unrecognized test line: // errorcheck -0 -N -d=nil
> go.test/test/nilptr3.go: unrecognized test line: // errorcheck -0 -d=nil

Thanks, not sure how I missed those.  Those tests are really testing
specific gc compiler behaviour anyhow, so we should just skip them
with gccgo.  This patch does that.  Committed to mainline.

Ian


2014-01-09  Ian Lance Taylor  <iant@google.com>

	* go.test/go-test.exp (go-gc-tests): Skip nilptr tests that test
	the other Go compiler.


Index: go.test/go-test.exp
===================================================================
--- go.test/go-test.exp	(revision 206473)
+++ go.test/go-test.exp	(working copy)
@@ -1143,6 +1143,10 @@ proc go-gc-tests { } {
 		   || $test_line == "// \$G \$D/pkg.go && pack grcS pkg.a pkg.\$A
2> /dev/null && rm pkg.\$A && \$G -I. -u \$D/main.go" } {
 	    # This tests the gc -u option, which gccgo does not
 	    # support.
+	} elseif { $test_line == "// errorcheck -0 -N -d=nil" \
+		       || $test_line == "// errorcheck -0 -d=nil" } {
+	    # This tests gc nil pointer checks using -d=nil, which
+	    # gccgo does not support.
 	} else {
 	    clone_output "$name: unrecognized test line: $test_line"
 	    unsupported $name



More information about the Gcc-patches mailing list