[PATCH, go]: Skip some go tests

Uros Bizjak ubizjak@gmail.com
Thu Jan 9 17:11:00 GMT 2014


On Thu, Jan 9, 2014 at 4:01 PM, Ian Lance Taylor <iant@google.com> wrote:
> On Thu, Jan 9, 2014 at 2:54 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>> 2014-01-09  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     * go.test/go-test.exp (go-gc-tests): Don't run peano.go on systems
>>     which don't support -fsplit-stack.  Skip rotate[0123]-out.go.
>
> This is OK.  Thanks.
>
> You might want to tweak the comment just under where you added
> "peano.go".  Then go ahead and commit.

Actually, we don't even have to compile/execute generator file, and
included rotate.go is skipped due to "// skip" in its test line.

Attached patch was committed to mainline after re-test on x86_64-pc-linux-gnu.

Uros.
-------------- next part --------------
Index: go.test/go-test.exp
===================================================================
--- go.test/go-test.exp	(revision 206468)
+++ go.test/go-test.exp	(working copy)
@@ -400,17 +400,16 @@
 	}
 
 	if { ( [file tail $test] == "select2.go" \
-		   || [file tail $test] == "stack.go" ) \
+		   || [file tail $test] == "stack.go" \
+		   || [file tail $test] == "peano.go" ) \
 		 && ! [check_effective_target_split_stack] } {
-	    # chan/select2.go fails on targets without split stack,
-	    # because they allocate a large stack segment that blows
-	    # out the memory calculations.
+	    # These tests fails on targets without split stack.
 	    untested $name
 	    continue
 	}
 
-	if { [file tail $test] == "rotate.go" } {
-	    # This test produces a temporary file that takes too long
+	if [string match "*go.test/test/rotate\[0123\].go" $test] {
+	    # These tests produces a temporary file that takes too long
 	    # to compile--5 minutes on my laptop without optimization.
 	    # When compiling without optimization it tests nothing
 	    # useful, since the point of the test is to see whether


More information about the Gcc-patches mailing list