[PATCH] Fix PR59715

Tom de Vries Tom_deVries@mentor.com
Thu Jan 9 12:10:00 GMT 2014

On 09-01-14 10:16, Richard Biener wrote:
> This fixes PR59715 by splitting critical edges again before
> code sinking.  The critical edge splitting done before PRE
> was designed to survive until sinking originally, but at least
> since 4.5 PRE now eventually cleans up the CFG and thus undos
> critical edge splitting.  This results in less than optimal
> code placement (and lost opportunities) for sinking and it
> breaks (at least) the virtual operand updating code which
> assumes that critical edges are still split.


this follow-up patch:
- notes in pass_pre that PROP_no_crit_edge is destroyed
- notes in pass_sink_code that PROP_no_crit_edge is not required
   (because it's now ensured by the pass itself)

Build and reg-tested pr59715.c on x86_64.

OK for stage3 trunk if bootstrap and full reg-test on x86_64 is ok?

- Tom

-------------- next part --------------
A non-text attachment was scrubbed...
Name: prop-no-crit-edges.patch
Type: text/x-patch
Size: 1566 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140109/9080274d/attachment.bin>

More information about the Gcc-patches mailing list