[PATCH, go]: Skip some go tests

Uros Bizjak ubizjak@gmail.com
Thu Jan 9 10:54:00 GMT 2014


Hello!

Attached patch skip some go tests to avoid testsuite failures:

- peano.go tests recursive call. The test fails on targets that don't
support -fsplit-stack (Centos 5.3, alpha)
- rotate[0123]-out.go take too long to compile. The test should be
skipped for the same reason as rotate.go:

        # This test produces a temporary file that takes too long
        # to compile--5 minutes on my laptop without optimization.
        # When compiling without optimization it tests nothing
        # useful, since the point of the test is to see whether
        # the compiler generates rotate instructions.

There are two remaining warnings:

go.test/test/nilcheck.go: unrecognized test line: // errorcheck -0 -N -d=nil
go.test/test/nilptr3.go: unrecognized test line: // errorcheck -0 -d=nil

(The patch doesn't address these warnings).

2014-01-09  Uros Bizjak  <ubizjak@gmail.com>

    * go.test/go-test.exp (go-gc-tests): Don't run peano.go on systems
    which don't support -fsplit-stack.  Skip rotate[0123]-out.go.

Patch was tested on alpha-linux-gnu, where it fixes all but
recovery.go failure; the latter due to unimplemented feature on alpha
target.

OK for mainline?

Uros.
-------------- next part --------------
Index: go-test.exp
===================================================================
--- go-test.exp	(revision 206441)
+++ go-test.exp	(working copy)
@@ -400,7 +400,8 @@
 	}
 
 	if { ( [file tail $test] == "select2.go" \
-		   || [file tail $test] == "stack.go" ) \
+		   || [file tail $test] == "stack.go" \
+		   || [file tail $test] == "peano.go" ) \
 		 && ! [check_effective_target_split_stack] } {
 	    # chan/select2.go fails on targets without split stack,
 	    # because they allocate a large stack segment that blows
@@ -409,7 +410,8 @@
 	    continue
 	}
 
-	if { [file tail $test] == "rotate.go" } {
+	if { ( [file tail $test] == "rotate.go" \
+		   || [file tail $test] == "rotate\[0123\]-out.go" ) } {
 	    # This test produces a temporary file that takes too long
 	    # to compile--5 minutes on my laptop without optimization.
 	    # When compiling without optimization it tests nothing


More information about the Gcc-patches mailing list