[PATCH] Allow building if libsanitizer on RHEL5 (i.e. with 2.6.18-ish kernel headers, take 2)

Dodji Seketeli dodji@redhat.com
Thu Jan 9 08:55:00 GMT 2014


Jakub Jelinek <jakub@redhat.com> writes:

> Hi!
>
> Here is an updated version which doesn't warn about #include_next.
> Ok for trunk?
>
> 2013-12-10  Jakub Jelinek  <jakub@redhat.com>
>
> 	* sanitizer_common/Makefile.am (AM_CPPFLAGS): Add
> 	-isystem $(top_srcdir)/include/system.
> 	* sanitizer_common/Makefile.in: Regenerated.
> 	* include/system/linux/aio_abi.h: New header.
> 	* include/system/linux/mroute.h: New header.
> 	* include/system/linux/mroute6.h: New header.
> 	* include/system/linux/perf_event.h: New header.
> 	* include/system/linux/types.h: New header.

This looks good to me.  A better approach would have been what you said
in another thread:

    | much better would be just say a testcase that would include the
    | sanitizer + kernel headers, guarded by recent enough LINUX_VERSION_CODE
    | or configure or similar, so it wouldn't prevent library build on older
    | kernel headers, the kernel ABI better be stable (only new things added,
    | not size of structures/magic constants etc. changed from time to time).

But because of:

    | But Kostya is apparently not willing to do that, so this patch
    | provides a workaround in non-compiler-rt maintained files.

Let's get this in then :-)

Cheers.

-- 
		Dodji



More information about the Gcc-patches mailing list