[Patch, bfin/c6x] Fix ICE for backends that rely on reorder_loops.

Jeff Law law@redhat.com
Thu Jan 9 04:20:00 GMT 2014


On 01/07/14 09:07, Bernd Schmidt wrote:
> On 01/05/2014 05:10 PM, Teresa Johnson wrote:
>> On Sun, Jan 5, 2014 at 3:39 AM, Bernd Schmidt
>> <bernds@codesourcery.com> wrote:
>>> I have a different patch which I'll submit next week after some more
>>> testing. The assert in cfgrtl is unnecessarily broad and really only
>>> needs
>>> to trigger if -freorder-blocks-and-partition; there's nothing wrong with
>>> entering cfglayout after normal bb-reorder.
>>
>> Currently -freorder-blocks-and-partition is the default for x86. I
>> assume that hw-doloop is not enabled for any i386 targets, which is
>> why we haven't seen this?
>
> Precisely.
>
>> And will this mean that -freorder-blocks-and-partition cannot be used
>> for the targets that use hw-doloop? If so, should
>> -freorder-blocks-and-partition be prevented with a warning for those
>> targets?
>
> If someone explicitly chooses that option we can turn off the reordering
> in hw-doloop. That should happen sufficiently rarely that it isn't a
> problem. That's what the patch below does - bootstraped on x86_64-linux,
> tested there and with bfin-elf. Ok?
Yes.  This is fine.

jeff



More information about the Gcc-patches mailing list