FW: [PATCH] Fix PR 59631

Iyer, Balaji V balaji.v.iyer@intel.com
Wed Jan 8 17:12:00 GMT 2014


A small but major typo.

The second sentence should read "...usage of _Cilk_spawn [ and _Cilk_sync] *without* -fcilkplus..." instead of "...with -fcilkplus..."
 
I am sorry about this.

Sincerely,

Balaji V. Iyer.

> -----Original Message-----
> From: Iyer, Balaji V
> Sent: Tuesday, January 7, 2014 10:15 AM
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] Fix PR 59631
> 
> Hello Everyone,
> 	The attached patch will fix the issue reported in PR 59631. The main
> issue was the usage of Cilk spawn [and _Cilk_sync] with -fcilkplus caused an
> ICE. This patch should fix that. The issue was only reported for C++ but the
> issue exists in C compiler also.  This patch fixes both C and C++. A test case is
> also included.
> 
> Is this Ok for trunk?
> 
> Here are the ChangeLog entries:
> +++ gcc/c/ChangeLog
> +2014-01-07  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> +
> +       PR c++/59631
> +       * c-parser.c (c_parser_postfix_expression): Replaced consecutive if
> +       statements with if-elseif statements.
> 
> +++ gcc/testsuite/ChangeLog
> +2014-01-07  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> +
> +       PR c++/59631
> +       * gcc.dg/cilk-plus/cilk-plus.exp: Removed "-fcilkplus" from flags list.
> +       * g++.dg/cilk-plus/cilk-plus.exp: Likewise.
> +       * c-c++-common/cilk-plus/CK/spawnee_inline.c: Replaced second dg-
> option
> +       with dg-additional-options.
> +       * c-c++-common/cilk-plus/CK/varargs_test.c: Likewise.
> +       * c-c++-common/cilk-plus/CK/steal_check.c: Likewise.
> +       * c-c++-common/cilk-plus/CK/spawner_inline.c: Likewise.
> +       * c-c++-common/cilk-plus/CK/spawning_arg.c: Likewise.
> +       * c-c++-common/cilk-plus/CK/invalid_spawns.c: Added a dg-options
> tag.
> +       * c-c++-common/cilk-plus/CK/pr59631.c: New testcase.
> 
> +++ gcc/cp/ChangeLog
> +2014-01-07  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> +
> +       PR c++/59631
> +       * parser.c (cp_parser_postfix_expression): Added a new if-statement
> +       and replaced an existing if-statement with else-if statement.
> +       Changed an existing error message wording to match the one from the
> C
> +       parser.
> 
> Thanks,
> 
> Balaji V. Iyer.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140108/acaadb72/attachment.txt>


More information about the Gcc-patches mailing list