[PATCH] _Cilk_for for C and C++

Iyer, Balaji V balaji.v.iyer@intel.com
Mon Jan 6 22:29:00 GMT 2014


Hi Everyone,
	Attached, please find two patches: 1 for _Cilk_for for C   and 1 for C++, and changelog entries for them. It is written on top of the omp framework and uses its trees and functions as requested by Jason and Jeff. It does not interfere with any other tests (i.e. pass things that are failing and fail things that are passing). It is tested and works on x86 and x86_64.

Is this Ok for trunk?

Thanks,

Balaji V. Iyer.

> -----Original Message-----
> From: Jason Merrill [mailto:jason@redhat.com]
> Sent: Monday, December 16, 2013 4:22 PM
> To: Iyer, Balaji V; 'Jeff Law'; 'Aldy Hernandez'
> Cc: 'gcc-patches@gcc.gnu.org'; 'rth@redhat.com'; 'Jakub Jelinek'
> Subject: Re: [PATCH] _Cilk_for for C and C++
> 
> On 12/15/2013 07:40 PM, Iyer, Balaji V wrote:
> > -		       tree clauses, tree *cclauses)
> > +		       tree clauses_or_grain, tree *cclauses)
> 
> Instead of this, please make the grainsize a new type of clause.
> 
> > -  return (gimple_omp_subcode (g) & GF_OMP_FOR_COMBINED) != 0;
> > +  return (gimple_omp_for_kind (g) == GF_OMP_FOR_COMBINED);
> 
> I don't really know this code, but this change seems unlikely to be correct.
> Can you explain it?
> 
> > +  tree data_name = get_identifier (".omp_data_i");  if (is_cilk_for)
> > +    data_name = get_identifier (".cilk_for_data_i");
> 
> Why does the name of an artificial parameter matter?
> 
> >  }
> > +/* A subroutine of expand_omp_for.  Generate code for _Cilk_for loop.
> > +   Given parameters:
> 
> Need a blank line after the }.
> 
> Jason

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff_c.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140106/d0641d80/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff_c++.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140106/d0641d80/attachment-0001.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: c-ChangeLog
Type: application/octet-stream
Size: 4350 bytes
Desc: c-ChangeLog
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140106/d0641d80/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cp-ChangeLog
Type: application/octet-stream
Size: 1532 bytes
Desc: cp-ChangeLog
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140106/d0641d80/attachment-0001.obj>


More information about the Gcc-patches mailing list