[PATCH] Handle more COMDAT profiling issues

Mike Stump mikestump@comcast.net
Thu Feb 13 17:49:00 GMT 2014


On Feb 13, 2014, at 8:41 AM, Teresa Johnson <tejohnson@google.com> wrote:
> On Wed, Feb 12, 2014 at 2:03 PM, Xinliang David Li <davidxl@google.com> wrote:

[ extra lines deleted ]

>> Should non comdat function be skipped?
> 
> We warn in drop_profile if this is not a COMDAT, as we should only
> have this case and reach the call in that case. (See the check in
> drop_profile and the comments at the top of handle_missing_profile for
> more info)

[ more extra lines deleted ]

Can we edit out the extra lines when they get this large?  Not doing that is actually worse than top-posting.


More information about the Gcc-patches mailing list