[PATCH] S390: Fix crash with -mhotpatch and gfortran

Dominik Vogt vogt@linux.vnet.ibm.com
Thu Feb 13 05:48:00 GMT 2014


On Wed, Feb 12, 2014 at 11:34:16AM +0000, Richard Sandiford wrote:
> Dominik Vogt <vogt@linux.vnet.ibm.com> writes:
> > diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c
> > index 32a25a4..9ae8ffd 100644
> > --- a/gcc/config/s390/s390.c
> > +++ b/gcc/config/s390/s390.c
> > @@ -5510,9 +5510,8 @@ s390_asm_output_function_label (FILE *asm_out_file, const char *fname,
> >        if (hotpatch_trampoline_halfwords >= 0
> >  	  && decl_function_context (decl) != NULL_TREE)
> >  	{
> > -	  warning_at (0, DECL_SOURCE_LOCATION (decl),
> > -		      "hotpatch_prologue is not compatible with nested"
> > -		      " function");
> > +	  warning_at (0, OPT_mhotpatch,
> > +		      "hotpatching is not compatible with nested functions");
> 
> Looks like this should be:
> 
> 	  warning_at (DECL_SOURCE_LOCATION (decl), OPT_mhotpatch,
> 		      "hotpatching is not compatible with nested functions");

Yep, see updated patch.  Thanks.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc-4.9-2-0001-S390-Fix-crash-when-mhotpatch-encounters-nested-func.patch
Type: text/x-diff
Size: 1001 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140213/e9f51866/attachment.bin>
-------------- next part --------------
2014-02-12  Dominik Vogt  <vogt@linux.vnet.ibm.com>

	* config/s390/s390.c (s390_asm_output_function_label):
	fix crash caused by bad second argument to warning_at() with -mhotpatch
	and nested functions (e.g. with gfortran)


More information about the Gcc-patches mailing list