[ARM] [Churn] Comments on cost tables should have lower-case identifiers.

James Greenhalgh james.greenhalgh@arm.com
Wed Feb 12 12:34:00 GMT 2014


Hi,

This patch fixes a nuisance with the comments in the cost tables.
Presently they are in sentence case, which to any casual observer
(i.e. me) would suggest that the field name should begin with
an upper-case character, .Fma for example. Also irritating is trying
to find the cost of the real .fma, which a case-sensitive grep won't
spot. GNU style explicitly calls this sort of mangling of identifiers
out as bad practice.

I've checked that both AArch64 and ARM toolchains still build after
this minor change.

OK for trunk/stage-1 (I don't mind which)?

Thanks,
James

---
gcc/

2014-02-12  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/arm/aarch-cost-tables
	(generic_extra_costs): Fix identifiers in comments.
	(cortexa53_extra_costs): Likewise.
	* config/arm/arm.c
	(cortexa9_extra_costs): Fix identifiers in comments.
	(cortexa7_extra_costs): Likewise.
	(cortexa12_extra_costs): Likewise.
	(cortexa15_extra_costs): Likewise.
	(v7m_extra_costs): Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-Churn-Comments-on-cost-tables-should-have-lower-.patch
Type: text/x-patch
Size: 39883 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140212/ea2091c2/attachment.bin>


More information about the Gcc-patches mailing list