print quotes around )

Joseph S. Myers joseph@codesourcery.com
Tue Feb 11 00:05:00 GMT 2014


On Sun, 9 Feb 2014, Prathamesh Kulkarni wrote:

> On Sun, Feb 9, 2014 at 8:31 PM, Prathamesh Kulkarni
> <bilbotheelffriend@gmail.com> wrote:
> > A trivial fix to print quotes around ) in libcpp/macro.c
> > OK for trunk ?
> Will not work for if pfile->cb.error callback does not recognize %< and %>
> (maybe clients other than c, c++ front-ends ?).
> So we cannot include %< and %> in the error message ?

Certainly not while the callback is declared ATTRIBUTE_FPTR_PRINTF, I'd 
have expected the bootstrap to fail with -Werror warnings....  (Declaring 
the callback to allow GCC-internal formats might have corresponding 
requirements for particular types to be declared first, where the 
format-checking machinery knows how GCC-internal formats use GCC-internal 
typedefs; you'd need to check.)

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list