[C,C++] integer constants in attribute arguments

Marc Glisse marc.glisse@inria.fr
Sun Feb 2 18:53:00 GMT 2014


On Sun, 2 Feb 2014, Joseph S. Myers wrote:

> On Sat, 1 Feb 2014, Marc Glisse wrote:
>
>> Ping
>> http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01168.html
>
> As I understand it, this is only relevant to C++ (in C you should have an
> INTEGER_CST here, and if you don't then default_conversion won't give you
> one), so would best be reviewed by Jason not me.

I agree, I just wanted to make sure you weren't opposed to using 
default_conversion in C as well and were ok with my explanation of why I 
was testing FUNCTION_DECL for some attributes (in C++, default_conversion 
will accept anything, so I am doing that for the sake of C).

An alternative could be to have a helper function that does nothing in C 
and calls default_conversion in C++. Or make the C version of 
default_conversion return its argument unchanged instead of asserting when 
it sees an unexpected tree.

I'll wait for Jason, thanks.

-- 
Marc Glisse



More information about the Gcc-patches mailing list