[PATCH, Fortran] PR fortran/60414 fix ICE was: PR 60414: Patch proposal

[Mikael Morin]

Hello,

Le 06/08/2014 21:23, Andre Vehreschild a écrit :
> Hi,
> 
[...]
> 
> *** gcc/fortran/Changelog ***
> 2014-08-06  Andre Vehreschild  <vehre@gmx.de>
> 
>         PR fortran/60414
>         * interface.c (compare_parameter): Fixing ICE when argument 
> 	of a generic is a reference into an array.
> *** gcc/fortran/Changelog ***
The ChangeLog format is good, but the text is not very
helpful/descriptive for someone hunting a bug in compare_parameter in
the future.

You can say (for example):
Remove class argument rank check short circuit.

> 
> *** gcc/testsuite/Changelog ***
> 2014-08-06  Andre Vehreschild  <vehre@gmx.de>
> 
>         * gfortran.dg/unlimited_polymorphism_18.f90: Check according to
>         PR fortran/60414
> *** gcc/testsuite/Changelog ***
You should add PR fortran/60414 before like in the gcc/fortran Changelog,
and then the text just need to say new/new file/new test (see what the
other contributors use in the rest of the file).

> 
> Bootstrapped and regtested on x86_64-unkown-linux-gnu.
> 
The patch looks good to me.
With the ChangeLog fixes above, OK if/when the copyright assignment is
settled.

Thanks
Mikael