[PATCH] Keep patch file permissions in mklog

[Tom de Vries]

On 11-08-14 10:18, Yury Gribov wrote:
> On 08/11/2014 11:22 AM, Tom de Vries wrote:
>> I'm now using mktemp from File::Temp.
>
> The script now relies on external Perl modules. This is probably fine because
> AFAIK File::Temp and File::Copy are available included in all distributions.
>
> +use File::Copy "cp";
> +use File::Copy "mv";
>
> You could trade one line with qw(cp mv)...
>
> +    $tmp = mktemp("tmp.XXXXXXXX") or die "cannot create temp file: $!";
>
> Perhaps "Could not" like in other error messages?
>
> +    cp "$diff", "$tmp" or die "Could not copy patch file to temp file: $!";
>
> Script don't quote stuff in other places so quoting here is useless.
>

Updated according comments and retested.

Thanks again,
- Tom


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-inline-option-to-contrib-mklog.patch
Type: text/x-patch
Size: 2453 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140811/b5c24e8d/attachment.bin>