Remove unnecessary and harmful fixincludes for Android

enh enh@google.com
Wed Aug 6 00:09:00 GMT 2014


does https://android-review.googlesource.com/103445 look okay?

On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb <bkorb@gnu.org> wrote:
> Hi,
>
> On Tue, Aug 5, 2014 at 10:36 AM, enh <enh@google.com> wrote:
>> you can see the current version of bionic's stdio.h here:
>>
>> https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h
>>
>> i'm happy to add any string to the header file that makes things
>> easier. if you want 'x-gcc-no-fixincludes' or whatever in there, just
>> say :-)
>
> That would be great, but you could also add:
>
>    /* this file depends on __gnuc_va_list being used for va_list */
>
> and not bother changing fixincludes at all. :)  But either of those two
> comments added to the header would be preferable to looking for "BIONIC".
> Thank you!
>
> With one of the two changes, the patch is approved.   Thanks!



More information about the Gcc-patches mailing list