-Wvariadic-macros does not print warning

[Manuel López-Ibáñez]

On 23 April 2014 20:03, Prathamesh Kulkarni <bilbotheelffriend@gmail.com> wrote:
> I didn't attach the patch, I am extremely sorry for the noise.
> I am re-posting the mail.
> This is a follow up mail to http://gcc.gnu.org/ml/gcc-help/2014-04/msg00096.html
> I have attached patch that prints the warning when passed -Wvariadic-macros
> (I mostly followed it along lines of -Wlong-long).
> OK for trunk ?

Hi Prathamesh,

Thanks for CCing me! I cannot approve patches, but it looks almost
perfect to me. Did you run the regression testsuite and compare the
results before/after your patch? I would expect at least one testcase
testing this warning that would be affected by the change. If not, it
would be nice to add testcases for this. Also, there is another place
that tests for both Wpedantic and Wvariadic-macros just above the one
that you modify. I think you should update all of them to just test
for Wvariadic-macros.

Once you do that, I hope Joseph will approve it quickly, it seems an
obvious fix to me for consistency with Wlong-long and to allow people
to use this warning without enabling Wpedantic (also, it will enable
the warning with Wtraditional as intended, which is currently broken).

Cheers,

Manuel.