[PATCH 01/89] Const-correctness fixes for some gimple accessors

David Malcolm dmalcolm@redhat.com
Mon Apr 21 22:45:00 GMT 2014


On Mon, 2014-04-21 at 12:43 -0600, Jeff Law wrote:
> On 04/21/14 10:56, David Malcolm wrote:
> > gcc/
> > 	* gimple.h (gimple_assign_single_p): Accept a const_gimple rather
> > 	than a gimple.
> > 	(gimple_store_p): Likewise.
> > 	(gimple_assign_load_p): Likewise.
> > 	(gimple_assign_cast_p): Likewise.
> > 	(gimple_clobber_p): Likewise.
> I know you bootstrapped the entire 89 patch series.  Generally when we 
> have a nice little independent patch like this, it should be separately 
> bootstrapped and tested so that it can go forward independent of 
> everything else.
> 
> Anyway, this is clearly OK and non-controversial.  OK for the trunk.
> 
> In fact, I would consider any const-correctness patch like this to be 
> pre-approved.

Thanks.

It was pointed out to me off-list that this patch series lacks
documentation changes.  I'm working on fixing that, though am not sure I
want to fill everyone inboxes with an updated set of patches yet.
Should I send a combined patch for the documentation changes?  (I can
break it up and merge it into the individual changes on commit, or if
these need editing).

In any case I fixed up the corresponding entries in gcc/doc/gimple.texi,
double-checked the bootstrap/regtest/HTML generation of this one (on top
of r209545), and committed it to trunk as r209548.  I'm attaching what I
actually committed.

Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r209548.patch
Type: text/x-patch
Size: 2826 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140421/f1518f82/attachment.bin>


More information about the Gcc-patches mailing list