[C++ Patch/RFC] Remove unify_success / unify_invalid unused parameter?

[Paolo Carlini]

Hi,

On 04/16/2014 09:47 PM, Jason Merrill wrote:
> On 04/15/2014 12:21 PM, Paolo Carlini wrote:
>> a lot of time ago I noticed that these parameters are unused: should I
>> prepare a ChangeLog for the below or we have stylistic, etc, reasons for
>> keeping the parameters?
>
> I'd leave them alone, we might want to print something sometime.
Makes sense.
>
>> PS: I also see many int return types in the various unify* which 
>> could as well be bool. Opinions about that?
>
> Doesn't seem worth bothering to change.
Ok. Personally, I believe that using bool instead of int, thus true and 
false instead of 1 and 0, may add clarity to the code whenever 0s and 1s 
are used as return values in the body of large functions, because one 
cannot wonder whether 2 and 3, etc, also would make sense (in fact 
elsewhere we have got functions returning int - not an enumeration type 
- with values outside 0 and 1 too, with special meanings... maybe those 
should be changed instead ;)

Paolo.