[PATCH] fixing typo in expr.c to allow proper recognition of complex addresses in some arches.

Eric Botcazou ebotcazou@adacore.com
Tue Oct 29 12:15:00 GMT 2013


> My reading of memory_address_addr_space is that MODE is the mode of the
> memory reference, not the mode of the address.  I fail to see how
> passing in the mode of the address in the first call can be correct.
> 
> What am I missing?

Nothing, it's me confusing

rtx memory_address_addr_space (enum machine_mode, rtx, addr_space_t);

with

rtx convert_memory_address_addr_space (enum machine_mode, rtx, addr_space_t);

for a long time apparently...  Sorry about that.  In the meantime, I installed 
the obvious patch to eliminate the small redundancy.  Tested on x86_64/Linux.


2013-10-29  Eric Botcazou  <ebotcazou@adacore.com>

	* expr.c (expand_expr_real_1) <MEM_EXPR>: Eliminate small redundancy.


-- 
Eric Botcazou
-------------- next part --------------
A non-text attachment was scrubbed...
Name: p.diff
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20131029/1cbbb515/attachment.bin>


More information about the Gcc-patches mailing list