[patch] omp-low.h

[Jakub Jelinek]

On Tue, Oct 15, 2013 at 10:46:43PM -0400, Andrew MacLeod wrote:
> Bootstraps on 86_64-unknown-linux-gnu and no new regressions.  OK?
> 
> Andrew

> 
> 	* tree-flow.h (struct omp_region): Move to omp-low.c

Missing dot at the end of line.

> 	Remove omp_ prototypes and variables.
> 	* gimple.h (omp_reduction_init): Move prototype to omp-low.h.
> 	(copy_var_decl): Relocate prototype from tree-flow.h.
> 	* gimple.c (copy_var_decl): Relocate from omp-low.c.
> 	* tree.h: Move prototype to omp-low.h.
> 	* omp-low.h: New File. Relocate prototypes here.

Missing space after .
> 	* omp-low.c (struct omp_region): Make local here.
> 	(root_omp_region): Make static.
> 	(copy_var_decl) Move to gimple.c.
> 	(new_omp_region): Make static.
> 	(make_gimple_omp_edges): New.  Refactored from tree-cfg.c make_edges.
> 	* tree-cfg.c: Include omp-low.h.
> 	(make_edges): Factor out OMP specific bits to make_gimple_omp_edges.
> 	* gimplify.c: Include omp-low.h.
> 	* tree-parloops.c: Include omp-low.h.

Use Likewise. for the second.

> 
> 	c
> 	* c-parser.c: Include omp-low.h.
> 	* c-typeck.c: Include omp-low.h.

Likewise.
> 
> 	cp
> 	* parser.c: Include omp-low.h.
> 	* semantics.c: Include omp-low.h.

Likewise.
> 
> 	fortran
> 	* trans-openmp.c: Include omp-low.h.

> *************** struct omp_for_data
> *** 135,141 ****
>   static splay_tree all_contexts;
>   static int taskreg_nesting_level;
>   static int target_nesting_level;
> ! struct omp_region *root_omp_region;
>   static bitmap task_shared_vars;
>   
>   static void scan_omp (gimple_seq *, omp_context *);
> --- 175,181 ----
>   static splay_tree all_contexts;
>   static int taskreg_nesting_level;
>   static int target_nesting_level;
> ! static struct omp_region *root_omp_region;
>   static bitmap task_shared_vars;
>   
>   static void scan_omp (gimple_seq *, omp_context *);

Why?

> --- 912,917 ----
> *************** debug_all_omp_regions (void)
> *** 1219,1225 ****
>   
>   /* Create a new parallel region starting at STMT inside region PARENT.  */
>   
> ! struct omp_region *
>   new_omp_region (basic_block bb, enum gimple_code type,
>   		struct omp_region *parent)
>   {
> --- 1238,1244 ----
>   
>   /* Create a new parallel region starting at STMT inside region PARENT.  */
>   
> ! static struct omp_region *
>   new_omp_region (basic_block bb, enum gimple_code type,
>   		struct omp_region *parent)
>   {

Likewise.

> +     case GIMPLE_OMP_CONTINUE:
...
> + 
> +       default:
> + 	gcc_unreachable ();

Bad indentation here, default: should be indented just by 4
spaces and gcc_unreachable () by 6.

Otherwise LGTM.

	Jakub