Enable building of libatomic on AArch64

Marcus Shawcroft marcus.shawcroft@gmail.com
Mon Oct 7 08:41:00 GMT 2013


On 3 October 2013 23:43, Michael Hudson-Doyle <michael.hudson@linaro.org> wrote:
> Hi,
>
> As libatomic builds for and the tests pass on AArch64 (built on x86_64
> but tested on a foundation model, logs and summary:
>
>     http://people.linaro.org/~mwhudson/libatomic.sum.txt
>     http://people.linaro.org/~mwhudson/runtest-log-v-2.txt
>
> ) this patch enables the build.
>
> Cheers,
> mwh
> (first time posting to this list, let me know if I'm doing it wrong)
>
> 2013-10-04  Michael Hudson-Doyle  <michael.hudson@linaro.org>
>
>           * configure.tgt: Add AArch64 support.
>

Hi,
The patch looks fine to me.

The ChangeLog entry should reflect the code that was removed rather
than the functionality added.  Perhaps:

          * configure.tgt (aarch64*): Remove.

Did you investigate whether or not the 10 UNSUPPORTED results in the
testsuite are sane?  I think that 5 look legitimate since they require
128 bit sync ops.  The other 5 look superficially like they should be
supported on aarch64.  We may just be missing aarch64 target supports
wiring in check_effective_target_sync_long_long_runtime?

/Marcus



More information about the Gcc-patches mailing list