[PING^2] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

Yufeng Zhang Yufeng.Zhang@arm.com
Tue Nov 26 14:53:00 GMT 2013


Ping^2

The patch was posted here:

http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01523.html

Thanks,
Yufeng

On 11/19/13 11:45, Yufeng Zhang wrote:
> Hi Richard,
>
> Can I get an approval or some feedback from you about the patch?
>
> Regards,
> Yufeng
>
> On 11/13/13 23:25, Yufeng Zhang wrote:
>> On 11/13/13 20:54, Bill Schmidt wrote:
>>> Hi Yufeng,
>>>
>>> The second version of your original patch is ok with me with the
>>> following changes.
>>
>> Thanks a lot for the review.  I've attached an updated patch with the
>> suggested changes incorporated.
>>
>>> Everything else looks OK to me.  Please ask Richard for final approval,
>>> as I'm not a maintainer.
>>
>> Hi Richard, would you be happy to OK the patch?
>>
>> Regards,
>> Yufeng
>>
>> gcc/
>>
>> 	* gimple-ssa-strength-reduction.c: Include tree-affine.h.
>> 	(name_expansions): New static variable.
>> 	(alt_base_map): Ditto.
>> 	(get_alternative_base): New function.
>> 	(find_basis_for_candidate): For CAND_REF, optionally call
>> 	find_basis_for_base_expr with the returned value from
>> 	get_alternative_base.
>> 	(record_potential_basis): Add new parameter 'base' of type 'tree';
>> 	add an assertion of non-NULL base; use base to set node->base_expr.
>> 	(alloc_cand_and_find_basis): Update; call record_potential_basis
>> 	for CAND_REF with the returned value from get_alternative_base.
>> 	(execute_strength_reduction): Call pointer_map_create for
>> 	alt_base_map; call free_affine_expand_cache with&name_expansions.
>>
>> gcc/testsuite/
>>
>> 	* gcc.dg/tree-ssa/slsr-41.c: New test.
>
>
>




More information about the Gcc-patches mailing list