[PATCH] Enhance ifcombine to recover non short circuit branches
Richard Biener
richard.guenther@gmail.com
Mon Nov 11 11:54:00 GMT 2013
On Fri, Nov 8, 2013 at 6:41 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Fri, Nov 8, 2013 at 6:20 PM, Steven Bosscher wrote:
>> On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote:
>>> Here is what I applied in the end; Jeff told me just to remove the
>>> testcase. I added the comment trying to explain why it was the
>>> opposite order of PHI-opt.
>>>
>>> Thanks,
>>> Andrew Pinski
>>>
>>> ChangeLog:
>>> * tree-ssa-ifcombine.c: Include rtl.h and tm_p.h.
>>
>> Eh, why???
>>
>> The file has this comment:
>>
>> 25 /* rtl is needed only because arm back-end requires it for
>> 26 BRANCH_COST. */
>> 27 #include "rtl.h"
>> 28 #include "tm_p.h"
>>
>> Can you please clarify why this is not something to be fixed in the
>> ARM back end?
>
>
> Could be fixed like attached. Can you please have a look and
> foster-parent it if you like it?
Looks good to me - Richard, can you pick it up?
Thanks,
Richard.
> Thanks,
>
> Ciao!
> Steven
More information about the Gcc-patches
mailing list