[PATCH] Fix incorrect discriminator assignment.

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Fri May 31 12:00:00 GMT 2013


Dehao Chen <dehao@google.com> writes:

> On Thu, May 30, 2013 at 10:41 AM, Cary Coutant <ccoutant@google.com> wrote:
>>> That's weird cause in dwarf2.exp:
>>>
>>> # If a testcase doesn't have special options, use these.
>>> global DEFAULT_CFLAGS
>>> if ![info exists DEFAULT_CFLAGS] then {
>>>     set DEFAULT_CFLAGS " -ansi -pedantic-errors -gdwarf-2"
>>> }
>>>
>>> But anyway, shall I add the -gdwarf-2 option back to discriminator.c?
>>
>> I think that gets overridden by dg-options. If you use {
>> dg-additional-options "-O2" } instead, it should still pass -gdwarf-2
>> (along with the other two).
>
> In the current test, I didn't use dg-options, but dg-additional-options instead:
>
> /* { dg-additional-options "-O0" } */

Indeed, and I see -ansi -pedantic-errors -gdwarf-2 -O0 used for the test
on both x86_64-unknown-linux-gnu and i386-pc-solaris2.10 (if I augment
the target clause).

Something unusual seems to be going on with Andreas' testing.  Any
RUNTESTFLAGS or DEJAGNU options in the environment?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Gcc-patches mailing list