[PING]RE: [patch] cilkplus: Array notation for C patch

[Iyer, Balaji V]

> -----Original Message-----
> From: Jeff Law [mailto:law@redhat.com]
> Sent: Thursday, May 30, 2013 5:02 PM
> To: Iyer, Balaji V
> Cc: David Edelsohn; Richard Henderson; Jakub Jelinek; Aldy Hernandez; 'Joseph
> S. Myers'; gcc-patches
> Subject: Re: [PING]RE: [patch] cilkplus: Array notation for C patch
> 
> On 05/30/2013 02:13 PM, Iyer, Balaji V wrote:
> > Hi David,
> > 	Please see my response below:
> >
> >> -----Original Message-----
> >> From: David Edelsohn [mailto:dje.gcc@gmail.com]
> >> Sent: Wednesday, May 29, 2013 11:44 AM
> >> To: Iyer, Balaji V
> >> Cc: Richard Henderson; Jakub Jelinek; Aldy Hernandez; Jeff Law; 'Joseph S.
> >> Myers'; gcc-patches
> >> Subject: RE: [PING]RE: [patch] cilkplus: Array notation for C patch
> >>
> >> Balaji,
> >>
> >> Thanks for this new feature and I am relieved that so much of it
> >> works successfully on PowerLinux and AIX.
> >>
> >> I know that you have received a deluge of reports of issues with the
> >> cilkplus support that you slowly are working through.  I am seeing
> >> the following new testsuite failures on AIX:
> >>
> >> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-
> plus/AN/sec_implicit2.c:
> >> In function 'main2':
> >> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-
> >> plus/AN/sec_implicit2.c:23:15:
> >> error: __sec_implicit_index parameter must be an integer constant
> >> expression
> >
> > I have this line flagged for error using dg-error.
> > Here is the cut and paste of it:
> >
> > =======================================================
> >    array[:][:] = __sec_implicit_index(argc) + array[:][:]; /* { dg-error
> "__sec_implicit_index parameter" } */
> >    return 0;
> >
> ================================================================
> Looking at my tree, dg-error refers to "argument" not "parameter"


Hmm.. I have used "__sec_implicit_index parameter" in dg-error. Here is the link from gcc-git web portal (http://gcc.gnu.org/git/?p=gcc.git;a=blob_plain;f=gcc/testsuite/c-c%2B%2B-common/cilk-plus/AN/sec_implicit2.c;hb=4a2ca8f34c2b84bbd04eff0d22f97046dfbd0f07)

Also, it should hit the error in function extract_sec_implicit_index_arg in the file array-notation-common.c (http://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/c-family/array-notation-common.c;h=1d288464eee6a8c805ef627d58c14249da5ae143;hb=4a2ca8f34c2b84bbd04eff0d22f97046dfbd0f07)  and it does have "__sec_implicit_index parameter..." 

I think David is getting the correct output but just that dg-error is not catching it correctly.

Thanks,

Balaji V. Iyer.