[PING]RE: [patch] cilkplus: Array notation for C patch

[Jeff Law]

On 05/30/2013 02:13 PM, Iyer, Balaji V wrote:
> Hi David,
> 	Please see my response below:
>
>> -----Original Message-----
>> From: David Edelsohn [mailto:dje.gcc@gmail.com]
>> Sent: Wednesday, May 29, 2013 11:44 AM
>> To: Iyer, Balaji V
>> Cc: Richard Henderson; Jakub Jelinek; Aldy Hernandez; Jeff Law; 'Joseph S.
>> Myers'; gcc-patches
>> Subject: RE: [PING]RE: [patch] cilkplus: Array notation for C patch
>>
>> Balaji,
>>
>> Thanks for this new feature and I am relieved that so much of it works
>> successfully on PowerLinux and AIX.
>>
>> I know that you have received a deluge of reports of issues with the cilkplus
>> support that you slowly are working through.  I am seeing the following new
>> testsuite failures on AIX:
>>
>> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-plus/AN/sec_implicit2.c:
>> In function 'main2':
>> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-
>> plus/AN/sec_implicit2.c:23:15:
>> error: __sec_implicit_index parameter must be an integer constant expression
>
> I have this line flagged for error using dg-error.
> Here is the cut and paste of it:
>
> =======================================================
>    array[:][:] = __sec_implicit_index(argc) + array[:][:]; /* { dg-error "__sec_implicit_index parameter" } */
>    return 0;
> ================================================================
Looking at my tree, dg-error refers to "argument" not "parameter"


>
> I just have a partial message inside quotes, not the whole thing. My x86_64 machine seem to accept it. I am not very familiar with deja-gnu, but does dg-error require the complete error message?

>>
>> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-
>> plus/AN/sec_reduce_max_min_ind.c:
>> In function 'main2':
>> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-
>> plus/AN/sec_reduce_max_min_ind.c:23:28:
>> error: __sec_reduce_min_ind or __sec_reduce_max_ind cannot have arrays
>> with dimension greater than 1
>> /nasfarm/dje/src/src/gcc/testsuite/c-c++-common/cilk-
>> plus/AN/sec_reduce_max_min_ind.c:27:28:
>> error: __sec_reduce_min_ind or __sec_reduce_max_ind cannot have arrays
>> with dimension greater than 1
>
> Same as above for this also.
Not sure about this one.  It's possible (I'd have to sit down with 
dg.exp for a while) that it's looking for "error: " immediately followed 
by your string.   If that's the case, then it's looking for
"error: cannot have arrays with dimension greater than"

which won't match
"error: __sec_reduce_min_ind or __sec_reduce_max_ind cannot have arrays 
with dimension greater than"

jeff

>