[PATCH, AArch64] Support BFI instruction and insv standard pattern

Ian Bolton ian.bolton@arm.com
Thu May 30 11:33:00 GMT 2013


> On 05/20/2013 11:55 AM, Ian Bolton wrote:
> > I improved this patch during the work I did on the recent insv_imm
> patch
> > (http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01007.html).
> 
> Thanks, you cleaned up almost everything on which I would have
> commented
> with the previous patch revision.  The only thing left is:
> 
> > +  else if (!register_operand (value, <MODE>mode))
> > +    operands[3] = force_reg (<MODE>mode, value);
> 
> Checking register_operand before force_reg is unnecessary; you're not
> saving a
> function call, and force_reg will itself perform the register check.

Thanks for the review, Richard.

Latest patch is attached, which fixes this.

Linux and bare-metal regression runs successful.

OK for trunk?

Cheers,
Ian


2013-05-30  Ian Bolton  <ian.bolton@arm.com>

gcc/
	* config/aarch64/aarch64.md (insv): New define_expand.
	(*insv_reg<mode>): New define_insn.

testsuite/
	* gcc.target/aarch64/insv_1.c: New test.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: aarch64-insv-patch-130530.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20130530/02e688f1/attachment.txt>


More information about the Gcc-patches mailing list