[PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs

Jakub Jelinek jakub@redhat.com
Fri May 24 15:09:00 GMT 2013


On Fri, May 24, 2013 at 05:05:52PM +0200, Eric Botcazou wrote:
> > 2013-05-23  Martin Jambor  <mjambor@suse.cz>
> > 
> > 	* tree-cfg.c (verify_expr): Verify that BIT_FIELD_REFs, IMAGPART_EXPRs
> > 	and REALPART_EXPRs have scalar type.
> 
> I cannot formally approve, but this looks the right test to me.

I agree it is desirable, but is it enough to ensure that they will be only
toplevel?  Can't you e.g. do a VIEW_CONVERT_EXPR from an integer type or
floating/vector type etc. to struct type, then the verifier wouldn't
discover there is VIEW_CONVERT_EXPR <struct S, BIT_FIELD_REF<whatever, 0, 32>>?

	Jakub



More information about the Gcc-patches mailing list