[PING]RE: [patch] cilkplus: Array notation for C patch

[Aldy Hernandez]

On 05/23/13 14:03, Jakub Jelinek wrote:
> On Thu, May 23, 2013 at 06:27:04PM +0000, Iyer, Balaji V wrote:
>> gcc/testsuite/ChangeLog
>> 2013-05-23  Balaji V. Iyer  <balaji.v.iyer@intel.com>
>>
>>          * gcc.dg/cilk-plus/array_notation/compile/array_test2.c: New test.
>
> I have concerns about the test locations, to me this looks way too deep
> tree, whether something is a compile test, or compile test expecting errors
> or runtime test is easily determined by { dg-do compile } vs. { dg-do run }
> and presence or lack of { dg-error ... } comments.  So IMHO that level
> should be left out, plus I'd say the array_notation/ level is unnecessary as
> well, just put everything into c-c++-common/cilk-plus/an-*.c
> (except for tests that aren't going to be usable for C++, those can stay in
> gcc.dg/cilk-plus/an-*.c).  Then gcc.dg/cilk-plus/*.exp would just ensure
> that tests from that directory are run and also from c-c++-common/ and later
> on the same would happen in g++.dg/cilk-plus/.  In the future when you will
> need to link against runtime library cilk-plus.exp would just arrange for
> that to be added to LD_LIBRARY_PATH, -L.../ etc.

For the record, I agree.