[Patch] Fix PR56780: --disable-install-libiberty still installs libiberty.a

Ian Lance Taylor iant@google.com
Wed May 22 20:28:00 GMT 2013


On Wed, Apr 3, 2013 at 7:03 AM, Matt Burgess
<matthew@linuxfromscratch.org> wrote:
>
> 2013-04-03 Matt Burgess <matthew@linuxfromscratch.org>
>
>         other/PR56780
>         * libiberty/configure.ac:
>         Move test for --enable-install-libiberty outside of the
> 'with_target_subdir' test so that it actually gets run.
>         Add output messages to show the test result.
>
>         * libiberty/configure:
>         Regenerate.
>
>         * libiberty/Makefile.in (install_to_libdir):
>         Place the installation of the libiberty library in the same guard as
> that used for the headers to prevent it being installed unless requested
> via --enable-install-libiberty.

Note that in the ChangeLog entry you should not have any blank lines,
and you should not break the lines after the colon.  See the existing
entries and follow their format.

> +[  --enable-install-libiberty       Install headers for end users],

Change this to "Install headers and library for end users" or
something like that.

This is OK with those changes.

Thanks, and sorry for the slow review.

Ian



More information about the Gcc-patches mailing list