[PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop

[Tom Tromey]

>>>>> "Shakthi" == Shakthi Kannan <skannan@redhat.com> writes:

Shakthi> 2013-05-10 Shakthi Kannan <skannan@redhat.com>
Shakthi>     PR preprocessor/42014
Shakthi>     * gcc/diagnostic.c: Added LAST_SOURCE_COLUMN in while loop.

You should mention the function name in there.
See the GNU Coding Standards for the format.

Shakthi> -			   ",\n                 from %s:%d",
Shakthi> -			   LINEMAP_FILE (map), LAST_SOURCE_LINE (map));
Shakthi> +			   ",\n                 from %s:%d:%d",
Shakthi> +			   LINEMAP_FILE (map),
Shakthi> +			   LAST_SOURCE_LINE (map), LAST_SOURCE_COLUMN (map));

Does this cause test suite regressions?

If so then the patch needs fixes there.
If not then the patch needs a new test.

Also, is the column number actually correct?
IIRC some things in cpp still don't get the right column number.

Tom