[PATCH] Fix thinko in SLSR that caused x86 bootstrap failure
Bill Schmidt
wschmidt@linux.vnet.ibm.com
Tue May 7 16:26:00 GMT 2013
On Tue, 2013-05-07 at 11:34 +0200, Jakub Jelinek wrote:
> On Mon, May 06, 2013 at 08:18:27PM -0500, Bill Schmidt wrote:
> > > AIL: gcc.dg/vect/vect-28.c -flto execution test
> > > FAIL: gcc.dg/vect/vect-28.c execution test
> > > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -fomit-frame-pointer
> > > execution test
> > > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -fomit-frame-pointer
> > > -funroll-all-loops -finline-functions execution test
> > > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -fomit-frame-pointer
> > > -funroll-loops execution test
> > > FAIL: gfortran.dg/array_constructor_9.f90 -O3 -g execution test
> > > FAIL: gfortran.dg/char_result_3.f90 -O3 -fomit-frame-pointer execution test
> > > FAIL: gfortran.dg/char_result_3.f90 -O3 -fomit-frame-pointer
> > > -funroll-all-loops -finline-functions execution test
> > > FAIL: gfortran.dg/char_result_3.f90 -O3 -fomit-frame-pointer
> > > -funroll-loops execution test
> > > FAIL: gfortran.dg/char_result_3.f90 -O3 -g execution test
> > > FAIL: gfortran.dg/cray_pointers_2.f90 -O execution test
> > > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -fomit-frame-pointer
> > > execution test
> > > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -fomit-frame-pointer
> > > -funroll-all-loops -finline-functions execution test
> > > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -fomit-frame-pointer
> > > -funroll-loops execution test
> > > FAIL: gfortran.dg/realloc_on_assign_2.f03 -O3 -g execution test
> > >
> > > on i686.
> > >
> > > --
> > > H.J.
> > >
> >
> > H.J., do you know whether the proposed patch fixes these failures? I'll
> > take a look at these tomorrow if not.
>
> +FAIL: gcc.dg/vect/vect-28.c execution test
> +FAIL: gcc.dg/vect/vect-28.c -flto execution test
>
> caused by the r198627 change isn't fixed with this patch (on i686-linux),
> while pr33017.c is. Similarly, on x86_64-linux, most of the new FAILs
> H.J. lists above are fixed (including many libgomp FAILs), but
> +FAIL: gfortran.dg/cray_pointers_2.f90 -O execution test
>
> +FAIL: libgomp.fortran/threadprivate2.f90 -O3 -fomit-frame-pointer execution test
> +FAIL: libgomp.fortran/threadprivate2.f90 -O3 -fomit-frame-pointer -funroll-loops execution test
> +FAIL: libgomp.fortran/threadprivate2.f90 -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions execution test
> +FAIL: libgomp.fortran/threadprivate2.f90 -O3 -g execution test
> still remain. For these x86_64 FAILs I haven't verified they were
> introduced by r198627, but they didn't fail May 3rd.
I see what's going on now. A rather fundamental mistake. Conditional
candidates only work for CAND_MULTs, but I neglected to enforce this.
*blush* Working on a fix. Amazed I didn't hit this.
Bill
>
> Jakub
>
More information about the Gcc-patches
mailing list