[cilkplus-merge] Handle generic pretty printing of ARRAY_NOTATION_REF
Iyer, Balaji V
balaji.v.iyer@intel.com
Wed Mar 27 17:02:00 GMT 2013
Yes, it looks OK.
Thanks,
Balaji V. Iyer.
> -----Original Message-----
> From: Aldy Hernandez [mailto:aldyh@redhat.com]
> Sent: Wednesday, March 27, 2013 12:32 PM
> To: gcc-patches; Iyer, Balaji V
> Subject: [cilkplus-merge] Handle generic pretty printing of
> ARRAY_NOTATION_REF
>
> While debugging some code I noticed that dump_generic_stmt() does not work
> on ARRAY_NOTATION_REFs. Attached is a patch adding the smarts to tree-
> pretty-print.
>
> There is no testcase because ARRAY_NOTATION_REFs are expanded by the
> parser, so by the time the tree dumps happen, there are no more
> ARRAY_NOTATION_REFs to look at.
>
> I am using TREE_OPERAND instead of the preferred ARRAY_NOTATION_*
> accessors, because these accessors are defined in c-family/c-common.h.
> Perhaps when both the C and C++ array notations are contributed, we could
> move the accessors to tree.h or something.
>
> Balaji, are you ok with these changes? If you are ok, I will commit this as a fairly
> trivial and obvious change.
More information about the Gcc-patches
mailing list