[patch] cilkplus array notation for C (clean, independent patchset, take 1)

Aldy Hernandez aldyh@redhat.com
Thu Mar 21 13:09:00 GMT 2013

On 03/21/13 08:06, Iyer, Balaji V wrote:
>> Balaji, please check the corresponding .sum files before and after your patch to
>> make sure that the same number of tests are being tested.  We have a nifty
>> script in contrib/compare_tests for this task.
> That's how I verify it. (I grep for the ^FAIL in trunk and the applied branch and make sure the output files are the same by going through it). Did I miss anything?

If you're using compare_tests, you should be fine.  But just grepping 
for FAIL won't do because there are tests that could have passed before, 
but are no longer being tested, so they don't show up as a fail.  I 
believe compare_tests complains with "tests that used to pass but have 
disappeared" (or something similar).

>> And as Jakub has said, check (with and) without parallelization.
> Yes, I am doing that also for the patch I am submitting.

Thank you.

More information about the Gcc-patches mailing list