[patch] Make dse.c dumps less verbose unless dumping details

Jeff Law law@redhat.com
Mon Mar 11 18:08:00 GMT 2013


On 03/09/2013 12:59 PM, Steven Bosscher wrote:
> Hello,
>
> Debugging a DSE bug, I found the dumps to be almost unusable because
> they are so verbose. For my test case, the -fdump-rtl-dse1 dump is a
> ~17GB file without the attached patch (the test case has ~50000
> insns). With the patch, all this extra information is only dumped with
> -fdump-rtl-dse1-details.
>
> Bootstrapped&tested on x86_64-unknown-linux-gnu and
> powerpc64-unknown-linux-gnu. Will commit as obvious.
>
> Ciao!
> Steven
>
> 	* dse.c (delete_dead_store_insn): Respect TDF_DETAILS.
> 	(canon_address, record_store, replace_read, check_mem_read_rtx,
> 	scan_insn, dse_step1, dse_step2_init, dse_step2_spill,
> 	dse_step4, dse_step5_nospill, dse_step5_spill, dse_step6,
> 	rest_of_handle_dse): Likewise.
Given we're trying to wrap up 4.8 and get an RC out, I would have 
preferred this not go in.  It's not strictly necessary to get 4.8 out 
the door.

Regardless, it's done and I'm certainly not going to suggest pulling the 
patch out.  In the future, please avoid any non-critical checkins this 
late in the game.

jeff



More information about the Gcc-patches mailing list